viirya commented on code in PR #1608:
URL: https://github.com/apache/arrow-rs/pull/1608#discussion_r857837664
##########
arrow/src/compute/kernels/substring.rs:
##########
@@ -168,8 +246,214 @@ pub fn substring(array: &dyn Array, start: i64, length:
Option<u64>) -> Result<A
mod tests {
use super::*;
- fn with_nulls<T: 'static + Array + PartialEq + From<Vec<Option<&'static
str>>>>(
- ) -> Result<()> {
+ #[allow(clippy::type_complexity)]
+ fn with_nulls_generic_binary<O: BinaryOffsetSizeTrait>() -> Result<()> {
Review Comment:
I know this follows string version `with_nulls`, just wondering why in
`with_nulls_...` only edge cases are tested against. `without_nulls_...` has
normal test cases but it doesn't include nulls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
