andygrove commented on code in PR #2339:
URL: https://github.com/apache/arrow-datafusion/pull/2339#discussion_r858070915


##########
datafusion/core/src/optimizer/utils.rs:
##########
@@ -223,6 +225,17 @@ pub fn from_plan(
             let right = &inputs[1];
             LogicalPlanBuilder::from(left).cross_join(right)?.build()
         }
+        LogicalPlan::Subquery(Subquery { .. }) => {
+            // let schema = inputs[0].schema().as_ref().clone().into();
+            // let schema =
+            //     DFSchemaRef::new(DFSchema::try_from_qualified_schema(alias, 
&schema)?);
+            // Ok(LogicalPlan::Subquery(Subquery {
+            //     subquery
+            //     input: Arc::new(inputs[0].clone()),
+            //     schema,
+            // }))
+            Err(DataFusionError::Plan("not implemented".to_string()))

Review Comment:
   I have now implemented this section of code, although it is not exercised by 
any tests yet



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to