pitrou commented on a change in pull request #7887:
URL: https://github.com/apache/arrow/pull/7887#discussion_r478519678
##########
File path: cpp/src/arrow/buffer_builder.h
##########
@@ -292,6 +292,11 @@ class TypedBufferBuilder<bool> {
return Status::OK();
}
+ void Forward(int64_t num_elements) {
Review comment:
This will leave some entries undefined unless they're written manually
elsewhere, which I don't think happens here.
I don't think this method is needed, instead you should just `Append(true)`
or `Append(length, true)`, IMHO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
