arw2019 commented on a change in pull request #8044:
URL: https://github.com/apache/arrow/pull/8044#discussion_r478814578
##########
File path: python/pyarrow/tests/test_pandas.py
##########
@@ -3531,11 +3533,11 @@ def test_dictionary_from_pandas_specified_type():
assert result.type.equals(typ)
assert result.to_pylist() == ['a', 'b']
- # mismatching values type -> raise error (for now a deprecation warning)
+ # mismatching values type -> raise error
typ = pa.dictionary(index_type=pa.int8(), value_type=pa.int64())
- with pytest.warns(FutureWarning):
+ with pytest.raises(pa.ArrowInvalid):
result = pa.array(cat, type=typ)
- assert result.to_pylist() == ['a', 'b']
+ assert result.to_pylist() == ["a", "b"]
Review comment:
removed
##########
File path: python/pyarrow/tests/test_compute.py
##########
@@ -562,7 +562,7 @@ def test_is_null():
def test_fill_null():
arr = pa.array([1, 2, None, 4], type=pa.int8())
fill_value = pa.array([5], type=pa.int8())
- with pytest.raises(TypeError):
+ with pytest.raises(pa.ArrowInvalid):
Review comment:
On master it's
``` python
TypeError: an integer is required (got type pyarrow.lib.Int8Array)
```
verus on this branch
``` python
ArrowInvalid: Could not convert [
5
] with type pyarrow.lib.Int8Array: tried to convert to int
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
