lidavidm commented on code in PR #12941:
URL: https://github.com/apache/arrow/pull/12941#discussion_r860857542
##########
java/memory/memory-core/src/test/java/org/apache/arrow/memory/util/TestArrowBufPointer.java:
##########
@@ -111,6 +111,7 @@ public void testNullPointersHashCode() {
}
@Test
+ @SuppressWarnings("ReturnValueIgnored")
Review Comment:
We can remove the suppression now right?
##########
java/pom.xml:
##########
@@ -690,7 +692,7 @@
<profiles>
<profile>
- <id>java-8</id>
+ <id>java-doclint</id>
Review Comment:
Should this be "nodoclint" or something?
##########
java/flight/flight-core/src/test/java/org/apache/arrow/flight/TestClientMiddleware.java:
##########
@@ -246,12 +246,13 @@ public FlightClientMiddleware onCallStarted(CallInfo
info) {
}
// Used to test that middleware can send and receive multi-valued text and
binary headers.
- static final Map<String, List<byte[]>> EXPECTED_BINARY_HEADERS = new
HashMap<String, List<byte[]>>() {{
- put("x-binary-bin", Arrays.asList(new byte[] {0}, new byte[]{1}));
- }};
- static final Map<String, List<String>> EXPECTED_TEXT_HEADERS = new
HashMap<String, List<String>>() {{
- put("x-text", Arrays.asList("foo", "bar"));
- }};
+ static final Map<String, List<byte[]>> EXPECTED_BINARY_HEADERS = new
HashMap<String, List<byte[]>>();
+ static final Map<String, List<String>> EXPECTED_TEXT_HEADERS = new
HashMap<String, List<String>>();
+
+ {
Review Comment:
```suggestion
static {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
