pitrou commented on a change in pull request #8071:
URL: https://github.com/apache/arrow/pull/8071#discussion_r478879104
##########
File path: cpp/cmake_modules/SetupCxxFlags.cmake
##########
@@ -47,8 +47,8 @@ if(ARROW_CPU_FLAG STREQUAL "x86")
else()
set(ARROW_SSE4_2_FLAG "-msse4.2")
set(ARROW_AVX2_FLAG "-mavx2")
- # skylake-avx512 consists of AVX512F,AVX512BW,AVX512VL,AVX512CD,AVX512DQ
- set(ARROW_AVX512_FLAG "-march=skylake-avx512 -mbmi2")
+ # Typical AVX512 subsets consists of AVX512F, AVX512BW, AVX512VL,
AVX512CD, AVX512DQ
+ set(ARROW_AVX512_FLAG "-mavx512f -mavx512cd -mavx512vl -mavx512dq
-mavx512bw -mbmi2")
Review comment:
Should we also keep `-march=...` to benefit from modern code selection
choices?
(also should we add `-march=something` to other flags above?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
