viirya commented on issue #1625: URL: https://github.com/apache/arrow-rs/issues/1625#issuecomment-1112820120
When constructing `UnionArray` in C++, `null_count` has been set to `0` explicitly: `SparseUnionArray`: https://github.com/apache/arrow/blob/c70426f73326b3852d1bd7c31d98be4743f3fcba/cpp/src/arrow/array/array_nested.cc#L696 `DenseUnionArray`: https://github.com/apache/arrow/blob/c70426f73326b3852d1bd7c31d98be4743f3fcba/cpp/src/arrow/array/array_nested.cc#L750 According to the default `IsNull` implementation, looks like `data_->null_count != data_->length` just gives us `false` always (except for length is `0`, but in the case `IsNull(i)` doesn't make sense too). So, seems returning `false` and adding some doc there should be good enough? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
