WillAyd commented on code in PR #12963:
URL: https://github.com/apache/arrow/pull/12963#discussion_r861425650
##########
cpp/src/arrow/compute/api_vector.h:
##########
@@ -174,6 +181,23 @@ class ARROW_EXPORT SelectKOptions : public FunctionOptions
{
std::vector<SortKey> sort_keys;
};
+/// \brief Rank options
+class ARROW_EXPORT RankOptions : public FunctionOptions {
+ public:
+ explicit RankOptions(SortOrder order = SortOrder::Ascending,
+ NullPlacement null_placement = NullPlacement::AtEnd,
+ Tiebreaker tiebreaker = Tiebreaker::First);
Review Comment:
I'm keeping tiebreaker as one word elsewhere throughout so I think this is
OK (?) but if not let me know and happy to change universally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
