pitrou commented on code in PR #12625:
URL: https://github.com/apache/arrow/pull/12625#discussion_r861531825
##########
cpp/src/arrow/filesystem/path_util.cc:
##########
@@ -287,6 +288,38 @@ bool IsLikelyUri(util::string_view v) {
return ::arrow::internal::IsValidUriScheme(v.substr(0, pos));
}
+struct Globber::Impl {
+ std::regex pattern_;
+
+ explicit Impl(std::string p) : pattern_(std::regex(std::move(transform(p))))
{}
+
+ std::string transform(std::string p) {
Review Comment:
> I think we can an escape in a previous step or say somewhere that for this
wildcards is needed to add an escape if they are not used as wildcards:
`s3://mybucket/foo/bar/?region=utopia&endpoint_override=localhost&scheme=http`
We are working on paths here, not URIs. The path in your example would be
`mybucket/foo.bar`
##########
cpp/src/arrow/filesystem/path_util.cc:
##########
@@ -287,6 +288,38 @@ bool IsLikelyUri(util::string_view v) {
return ::arrow::internal::IsValidUriScheme(v.substr(0, pos));
}
+struct Globber::Impl {
+ std::regex pattern_;
+
+ explicit Impl(std::string p) : pattern_(std::regex(std::move(transform(p))))
{}
+
+ std::string transform(std::string p) {
Review Comment:
> I think we can an escape in a previous step or say somewhere that for this
wildcards is needed to add an escape if they are not used as wildcards:
`s3://mybucket/foo/bar/?region=utopia&endpoint_override=localhost&scheme=http`
We are working on paths here, not URIs. The path in your example would be
`mybucket/foo/bar`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
