atefsawaed commented on code in PR #1621:
URL: https://github.com/apache/arrow-rs/pull/1621#discussion_r861656516
##########
parquet/src/column/writer.rs:
##########
@@ -1049,6 +1084,54 @@ fn has_dictionary_support(kind: Type, props:
&WriterProperties) -> bool {
}
}
+/// Signed comparison of bytes arrays
+fn compare_greater_byte_array_decimals(a: &[u8], b: &[u8]) -> bool {
+ let a_length = a.len();
+ let b_length = b.len();
+
+ if a_length == 0 || b_length == 0 {
+ return a_length > 0 && b_length == 0;
+ }
Review Comment:
Sort of. This is a safe check for empty buffers (that can represent null
values).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
