andygrove commented on code in PR #2369:
URL: https://github.com/apache/arrow-datafusion/pull/2369#discussion_r861842848
##########
datafusion/core/src/execution/context.rs:
##########
@@ -1887,26 +1885,6 @@ mod tests {
Ok(())
}
- #[tokio::test]
- async fn ctx_sql_should_optimize_plan() -> Result<()> {
- let ctx = SessionContext::new();
- let plan1 = ctx
- .create_logical_plan("SELECT * FROM (SELECT 1) AS one WHERE TRUE
AND TRUE")?;
-
- let opt_plan1 = ctx.optimize(&plan1)?;
-
- let plan2 = ctx
- .sql("SELECT * FROM (SELECT 1) AS one WHERE TRUE AND TRUE")
- .await?;
-
- assert_eq!(
Review Comment:
@alamb I made that change and I think that worked out well. The last commit
is quite large because I had to make `to_logical_plan` return a `Result` now so
had to update the call sites and I also stopped using this method internally
within `DataFrame` and replaced those calls with `self.plan.clone()` instead
(since that is what `to_logical_plan` was originally doing).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
