andygrove commented on code in PR #2373:
URL: https://github.com/apache/arrow-datafusion/pull/2373#discussion_r861898720
##########
datafusion/core/src/catalog/mod.rs:
##########
@@ -132,30 +129,3 @@ impl<'a> From<ResolvedTableReference<'a>> for
TableReference<'a> {
}
}
}
-
-impl<'a> TryFrom<&'a sqlparser::ast::ObjectName> for TableReference<'a> {
Review Comment:
We can't do this because we need to normalize the identifiers and that
requires creating new strings and that didn't go down well with the defined
lifetimes here, so I created a function in the SQL planner to do this
conversion instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
