jonkeane commented on code in PR #12589:
URL: https://github.com/apache/arrow/pull/12589#discussion_r861902304
##########
r/R/dplyr-funcs-datetime.R:
##########
@@ -357,6 +357,62 @@ register_bindings_duration <- function() {
delta <- delta$cast(int64())
start + delta$cast(duration("s"))
})
+ register_binding("fast_strptime", function(x,
+ format,
+ tz = "UTC",
+ lt = TRUE,
+ cutoff_2000 = 68L,
+ unit = "s") {
+ # TODO support multiple formats once
+ # https://issues.apache.org/jira/browse/ARROW-15665 is done
Review Comment:
Sure, a follow up is fine — though I'm curious what functionality we are
actually providing here if we're waiting for follow ups for this + don't
support the other options here. Maybe we defer implementing this at all until
the follow up where we add functionality beyond what `strptime` already does?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
