alamb commented on code in PR #2357:
URL: https://github.com/apache/arrow-datafusion/pull/2357#discussion_r862053645
##########
datafusion/core/src/physical_plan/planner.rs:
##########
@@ -964,7 +965,27 @@ pub fn create_physical_expr(
input_schema,
execution_props,
)?;
- binary(lhs, *op, rhs, input_schema)
+ match (
Review Comment:
I like this approach to use a specialized operator
I think over the long term, the ideal outcome would be to extend the arrow
temporal kernels
https://github.com/apache/arrow-rs/blob/master/arrow/src/compute/kernels/temporal.rs
with the actual calculation logic.
However, incubating the kernels within datafusion seems like a great idea
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
