westonpace commented on code in PR #12625:
URL: https://github.com/apache/arrow/pull/12625#discussion_r862119369
##########
cpp/src/arrow/filesystem/path_util.cc:
##########
@@ -287,6 +288,38 @@ bool IsLikelyUri(util::string_view v) {
return ::arrow::internal::IsValidUriScheme(v.substr(0, pos));
}
+struct Globber::Impl {
+ std::regex pattern_;
+
+ explicit Impl(std::string p) : pattern_(std::regex(std::move(transform(p))))
{}
+
+ std::string transform(std::string p) {
Review Comment:
I think escaping these characters could still potentially be a concern. `*`
and `?` are legal filename characters on Linux and S3.
s3://weston-my-bucket/*
https://weston-my-bucket.s3.amazonaws.com/* (even Github doesn't like this
:laughing: )
I'm fine with leaving that for a follow-up however.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
