andygrove commented on code in PR #2389: URL: https://github.com/apache/arrow-datafusion/pull/2389#discussion_r862485794
########## datafusion/physical-expr/src/struct_expressions.rs: ########## @@ -0,0 +1,109 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! Struct expressions + +use arrow::array::*; +use arrow::datatypes::{DataType, Field}; +use datafusion_common::{DataFusionError, Result}; +use datafusion_expr::ColumnarValue; +use std::sync::Arc; + +fn array_struct(args: &[ArrayRef]) -> Result<ArrayRef> { + // do not accept 0 arguments. + if args.is_empty() { + return Err(DataFusionError::Internal( + "struct requires at least one argument".to_string(), + )); + } + + let vec: Vec<_> = args + .iter() + .enumerate() + .map(|(i, arg)| -> (Field, ArrayRef) { + match arg.data_type() { + DataType::Utf8 => ( + Field::new(&*format!("f_{}", i), DataType::Utf8, true), Review Comment: `format!("f_{}", i)` is duplicated in each match. Could we create the column name once before the match statement? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
