viirya commented on code in PR #1633:
URL: https://github.com/apache/arrow-rs/pull/1633#discussion_r862611258
##########
arrow/src/compute/kernels/substring.rs:
##########
@@ -249,6 +304,8 @@ mod tests {
#[allow(clippy::type_complexity)]
fn with_nulls_generic_binary<O: BinaryOffsetSizeTrait>() -> Result<()> {
let cases: Vec<(Vec<Option<&[u8]>>, i64, Option<u64>,
Vec<Option<&[u8]>>)> = vec![
+ // all-nulls array is always identical
+ (vec![None, None, None], -1, Some(1), vec![None, None, None]),
Review Comment:
Thanks for adding test coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
