tustvold commented on code in PR #1632:
URL: https://github.com/apache/arrow-rs/pull/1632#discussion_r862773914
##########
arrow/src/array/array_union.rs:
##########
@@ -304,6 +304,24 @@ impl Array for UnionArray {
fn data(&self) -> &ArrayData {
&self.data
}
+
Review Comment:
Just to check, these special cases aren't necessary for correctness, but
just clarity?
##########
arrow/src/array/array_union.rs:
##########
@@ -304,6 +304,24 @@ impl Array for UnionArray {
fn data(&self) -> &ArrayData {
&self.data
}
+
Review Comment:
Just to check, these special cases aren't necessary for correctness, as the
ArrayData lacks a validity buffer, but just clarity?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
