ArianaVillegas commented on code in PR #12625:
URL: https://github.com/apache/arrow/pull/12625#discussion_r863926825
##########
cpp/src/arrow/filesystem/filesystem_test.cc:
##########
@@ -265,6 +265,24 @@ TEST(PathUtil, ToSlashes) {
#endif
}
+TEST(PathUtil, Globber) {
+ Globber localfs_linux("/f?o/bar/a?/1*.txt");
+ ASSERT_TRUE(localfs_linux.Matches("/foo/bar/a1/1.txt"));
+ ASSERT_TRUE(localfs_linux.Matches("/f#o/bar/ab/1000.txt"));
Review Comment:
Well, this path should be accepted because * includes /, but in practice '/'
is not allowed to be in a filename, I'll add something to avoid this, and I'll
add that test as a failing one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
