alamb commented on code in PR #2405:
URL: https://github.com/apache/arrow-datafusion/pull/2405#discussion_r864400327
##########
datafusion/physical-expr/src/aggregate/sum.rs:
##########
@@ -297,6 +297,18 @@ pub(crate) fn sum(lhs: &ScalarValue, rhs: &ScalarValue) ->
Result<ScalarValue> {
(ScalarValue::Int64(lhs), ScalarValue::Int8(rhs)) => {
typed_sum!(lhs, rhs, Int64, i64)
}
+ (ScalarValue::Int64(lhs), ScalarValue::UInt64(rhs)) => {
Review Comment:
I think @WinkerDu is just following the same pre-existing pattern with this
PR
I agree that the pre-existing pattern doesn't make sense to me (it should
have already been done by the time the distinct aggregate code is being
executed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
