zeroshade commented on code in PR #13059:
URL: https://github.com/apache/arrow/pull/13059#discussion_r864891322


##########
go/arrow/csv/reader_test.go:
##########
@@ -61,6 +62,11 @@ func Example() {
                n++
        }
 
+       err := r.Err()
+       if err != nil {
+               log.Fatal(err)
+       }

Review Comment:
   I'd say add a comment here to be more informative and explicit about the 
error handling



##########
go/arrow/csv/writer_test.go:
##########
@@ -81,6 +81,11 @@ func Example_writer() {
                n++
        }
 
+       err = r.Err()
+       if err != nil {
+               log.Fatal(err)
+       }

Review Comment:
   Same as above



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to