timvw commented on code in PR #2394:
URL: https://github.com/apache/arrow-datafusion/pull/2394#discussion_r865302923
##########
data-access/src/object_store/mod.rs:
##########
@@ -80,15 +83,42 @@ pub trait ObjectStore: Sync + Send + Debug {
prefix: &str,
suffix: &str,
) -> Result<FileMetaStream> {
- let file_stream = self.list_file(prefix).await?;
- let suffix = suffix.to_owned();
- Ok(Box::pin(file_stream.filter(move |fr| {
- let has_suffix = match fr {
- Ok(f) => f.path().ends_with(&suffix),
- Err(_) => true,
Review Comment:
@tustvold -> original code where the errors were allowed to pass (Would be
surprised to see anyone doing something meaningful with those..)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
