pitrou commented on a change in pull request #7898:
URL: https://github.com/apache/arrow/pull/7898#discussion_r480170645
##########
File path: cpp/src/arrow/array/array_dict_test.cc
##########
@@ -904,6 +905,79 @@ TEST(TestDecimalDictionaryBuilder, DoubleTableSize) {
ASSERT_TRUE(expected.Equals(result));
}
+TEST(TestNullDictionaryBuilder, Basic) {
+ // MakeBuilder
+ auto dict_type = dictionary(int8(), null());
+ std::unique_ptr<ArrayBuilder> boxed_builder;
+ ASSERT_OK(MakeBuilder(default_memory_pool(), dict_type, &boxed_builder));
+ auto& builder = checked_cast<DictionaryBuilder<NullType>&>(*boxed_builder);
+
+ ASSERT_OK(builder.AppendNull());
+ ASSERT_OK(builder.AppendNull());
+ ASSERT_OK(builder.AppendNull());
+ ASSERT_EQ(3, builder.length());
+ ASSERT_EQ(3, builder.null_count());
+
+ ASSERT_OK(builder.AppendNulls(4));
+ ASSERT_EQ(7, builder.length());
+ ASSERT_EQ(7, builder.null_count());
+
+ auto null_array = ArrayFromJSON(null(), "[null, null, null, null]");
+ ASSERT_OK(builder.AppendArray(*null_array));
+ ASSERT_EQ(11, builder.length());
+ ASSERT_EQ(11, builder.null_count());
+
+ std::shared_ptr<Array> result;
+ ASSERT_OK(builder.Finish(&result));
+ AssertTypeEqual(*dict_type, *result->type());
+ ASSERT_EQ(11, result->length());
+ ASSERT_EQ(11, result->null_count());
+}
+
+TEST(TestNullDictionaryBuilder, AppendArrayTypeMismatch) {
+ // MakeBuilder
+ auto dict_type = dictionary(int8(), null());
+ std::unique_ptr<ArrayBuilder> boxed_builder;
+ ASSERT_OK(MakeBuilder(default_memory_pool(), dict_type, &boxed_builder));
+ auto& builder = checked_cast<DictionaryBuilder<NullType>&>(*boxed_builder);
+
+ auto int8_array = ArrayFromJSON(int8(), "[0, 1, 0, null]");
+ ASSERT_DEBUG_DEATH({ (void)builder.AppendArray(*int8_array); },
+ "Wrong value type of array to be appended");
+}
+
+// ----------------------------------------------------------------------
+// Index byte width tests
+
+template <typename IndexType, typename ValueType>
+void AssertIndexByteWidth(const std::shared_ptr<DataType>& value_type =
+ TypeTraits<ValueType>::type_singleton()) {
+ auto index_type = TypeTraits<IndexType>::type_singleton();
+ auto dict_type =
+ checked_pointer_cast<DictionaryType>(dictionary(index_type, value_type));
+ std::unique_ptr<ArrayBuilder> builder;
+ ASSERT_OK(MakeBuilder(default_memory_pool(), dict_type, &builder));
+ auto builder_dict_type =
checked_pointer_cast<DictionaryType>(builder->type());
+ ASSERT_TRUE(dict_type->index_type()->Equals(builder_dict_type->index_type()))
Review comment:
`AssertTypeEqual`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
