AlenkaF commented on PR #13062: URL: https://github.com/apache/arrow/pull/13062#issuecomment-1118235181
I added a test that checks for `partitioning` and `file_visitor` being correctly passed in `pq.write_to_dataset`. While writing the test I bumped into another error. If the `basename_template` is specified as a keyword in `pq.write_to_dataset` (not being None) the code missed the check for `existing_data_behavior` and so the call to `ds.write_dataset` errored due to `existing_data_behavior` being None and not a string. I decided to add a correction here as this is also my leftover, but from https://github.com/apache/arrow/pull/12838. I could do a separate PR if there will be any opinion in favour of it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
