tustvold commented on code in PR #1647: URL: https://github.com/apache/arrow-rs/pull/1647#discussion_r866250325
########## arrow/src/datatypes/field.rs: ########## @@ -27,7 +28,7 @@ use super::DataType; /// Contains the meta-data for a single relative type. /// /// The `Schema` object is an ordered collection of `Field` objects. -#[derive(Serialize, Deserialize, Debug, Clone, PartialEq, Eq, Hash, PartialOrd, Ord)] +#[derive(Serialize, Deserialize, Debug, Clone, PartialOrd, Ord)] Review Comment: I think there might be funkiness if PartialOrd and PartialEq have different ideas of equality? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
