kou commented on code in PR #13063:
URL: https://github.com/apache/arrow/pull/13063#discussion_r866322677
##########
dev/tasks/vcpkg-tests/cpp-build-vcpkg.bat:
##########
@@ -70,6 +70,7 @@ cmake -G "Visual Studio 16 2019" -A x64 ^
-DARROW_WITH_SNAPPY=ON ^
-DARROW_WITH_ZLIB=ON ^
-DARROW_WITH_ZSTD=ON ^
+ -DGTest_SOURCE=SYSTEM ^
Review Comment:
It seems that ARROW-14560 is another problem and it has been fixed in
upstream.
Could you open a new JIRA issue for it?
How about just removing
https://github.com/apache/arrow/blob/master/cpp/cmake_modules/ThirdpartyToolchain.cmake#L80-L86
? The latest may solve the problem described in the comment.
If the problem isn't solved yet, we should report it to the conda's GTest
package. We can use `if(ARROW_DEPENDENCY_SOURCE STREQUAL "CONDA" AND MSVC AND
"${GTest_SOURCE}" STREQUAL "")` condition as a workaround for this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
