alamb opened a new pull request #8086:
URL: https://github.com/apache/arrow/pull/8086


   This PR proposes using `SchemaRef` (which is an `Arc<Schema>`) instead of 
`Box<Schema> `inside Datafusion to be consistent with the rest of the arrow 
implementation, avoid so many copies, and make the code simpler.
   
   A pretty good example of the simplification is:
   
   *before*:
   ```
   projected_schema: Box::new(csv.schema().as_ref().to_owned()),
   ```
   
   *after*:
   ```
   projected_schema: csv.schema().clone()),
   ```
   
   This code is not only clearer to understand in my opinion, it is also likely 
faster (it is a clone of an `Arc` (and an increment of a refcount) rather than 
a clone of the actual `Schema` itself)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to