andygrove commented on code in PR #2464:
URL: https://github.com/apache/arrow-datafusion/pull/2464#discussion_r866406536
##########
datafusion/core/src/sql/utils.rs:
##########
@@ -58,9 +59,13 @@ pub(crate) fn find_window_exprs(exprs: &[Expr]) -> Vec<Expr>
{
}
/// Collect all deeply nested `Expr::Column`'s. They are returned in order of
-/// appearance (depth first), with duplicates omitted.
+/// appearance (depth first), and may contain duplicates.
pub(crate) fn find_column_exprs(exprs: &[Expr]) -> Vec<Expr> {
- find_exprs_in_exprs(exprs, &|nested_expr| matches!(nested_expr,
Expr::Column(_)))
Review Comment:
This code was only finding some expressions and was not recursing and
finding them all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
