karldw commented on code in PR #12973:
URL: https://github.com/apache/arrow/pull/12973#discussion_r866790627
##########
r/tools/nixlibs.R:
##########
@@ -435,13 +435,22 @@ turn_off_all_optional_features <- function(env_var_list) {
# Because these are done as environment variables (as opposed to build
flags),
# setting these to "OFF" overrides any previous setting. We don't need to
# check the existing value.
+ # Some features turn on other features (e.g. engine -> substrait ->
protobuf),
+ # So the list of things to turn off is long. See:
+ #
https://github.com/apache/arrow/blob/master/cpp/cmake_modules/ThirdpartyToolchain.cmake#L275
turn_off <- c(
"ARROW_MIMALLOC" = "OFF",
"ARROW_JEMALLOC" = "OFF",
"ARROW_JSON" = "OFF",
"ARROW_PARQUET" = "OFF", # depends on thrift
"ARROW_DATASET" = "OFF", # depends on parquet
"ARROW_S3" = "OFF",
+ "ARROW_GCS" = "OFF",
Review Comment:
@nealrichardson, a quick ping here so this doesn't get lost. If the user has
a non-default environment variable like ARROW_GCS set to ON and the
dependencies aren't available, should the build:
1. Turn ARROW_GCS OFF or
2. Fail later when it tries to build the ARROW_GCS component?
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
