rok commented on PR #12657: URL: https://github.com/apache/arrow/pull/12657#issuecomment-1119619046
> > I suppose we can either document behaviour or let user choose the "origin unit". I would prefer to just document for now. > > Ah, letting the user choose could actually also be interesting: it leaves the custom logic to determine what the "greater unit" is to the R lubridate bindings, and it actually gives some flexibility to the user of the actual kernel (for example, you could want to round to a multiple of weeks since the start of the month or since the start of the year) Would that be a lot of code change to do? I'm honestly not sure about the change required. Right now we have 11 pairs of units and we'd go to 55 (?), plus we'd have more physical-to-calendar units interaction plus this then needs to be tested for zoned and nonzoned cases. I'd prefer to push that into a separate PR and unblock the R work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
