vibhatha commented on code in PR #13051:
URL: https://github.com/apache/arrow/pull/13051#discussion_r866890158
##########
cpp/src/arrow/compute/exec/hash_join_node.cc:
##########
@@ -453,6 +453,20 @@ Status
HashJoinSchema::CollectFilterColumns(std::vector<FieldRef>& left_filter,
return Status::OK();
}
+Status ValidateHashJoinNodeOptions(const HashJoinNodeOptions& join_options) {
+ if (join_options.key_cmp.size() < 1 || join_options.left_keys.size() < 1 ||
+ join_options.right_keys.size() < 1) {
Review Comment:
It matches the Status message as well.
##########
cpp/src/arrow/compute/exec/hash_join_node.cc:
##########
@@ -453,6 +453,20 @@ Status
HashJoinSchema::CollectFilterColumns(std::vector<FieldRef>& left_filter,
return Status::OK();
}
+Status ValidateHashJoinNodeOptions(const HashJoinNodeOptions& join_options) {
+ if (join_options.key_cmp.size() < 1 || join_options.left_keys.size() < 1 ||
+ join_options.right_keys.size() < 1) {
Review Comment:
Nit: Wouldn't it be better to call `empty()` on vectors?
For instance:
```c++
if (join_options.empty() || join_options.left_keys.empty() ||
join_options.right_keys.empty())
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
