rok commented on code in PR #12657:
URL: https://github.com/apache/arrow/pull/12657#discussion_r867053698
##########
cpp/src/arrow/compute/api_scalar.h:
##########
@@ -121,9 +121,13 @@ class ARROW_EXPORT RoundTemporalOptions : public
FunctionOptions {
/// Times exactly on unit multiple boundary will be rounded one unit
multiple up.
/// This applies for ceiling only.
bool strict_ceil;
- /// By default origin is 1970-01-01T00:00:00. By setting this to true,
rounding origin
- /// will be beginning of one less precise calendar unit. E.g. rounding to
hours will use
- /// beginning of day as origin.
+ /// By default time is rounded to a multiple of units since
1970-01-01T00:00:00.
+ /// By setting calendar_based_origin to true, time will be rounded to number
+ /// of units since the last greater calendar unit.
+ /// For example: rounding to multiple of days since the beginning of the
month or
+ /// to hours since the beginning of the day.
+ /// Please note: week and quarter are not used as greater units, therefor
days will
+ /// will be rounded to the beginning of the month not week.
Review Comment:
Changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
