alamb commented on code in PR #1636:
URL: https://github.com/apache/arrow-rs/pull/1636#discussion_r867140238
##########
arrow/src/ipc/reader.rs:
##########
@@ -457,7 +468,7 @@ pub fn read_record_batch(
buf: &[u8],
batch: ipc::RecordBatch,
schema: SchemaRef,
- dictionaries: &[Option<ArrayRef>],
+ dictionaries: &HashMap<i64, ArrayRef>,
Review Comment:
```suggestion
dictionaries_by_id: &HashMap<i64, ArrayRef>,
```
##########
arrow/src/ipc/reader.rs:
##########
@@ -54,14 +54,15 @@ fn read_buffer(buf: &ipc::Buffer, a_data: &[u8]) -> Buffer {
/// - cast the 64-bit array to the appropriate data type
fn create_array(
nodes: &[ipc::FieldNode],
- data_type: &DataType,
+ field: &Field,
data: &[u8],
buffers: &[ipc::Buffer],
- dictionaries: &[Option<ArrayRef>],
+ dictionaries: &HashMap<i64, ArrayRef>,
Review Comment:
```suggestion
dictionaries_by_id: &HashMap<i64, ArrayRef>,
```
Maybe this would more consistent with the names used in the rest of this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
