rtpsw commented on PR #13069: URL: https://github.com/apache/arrow/pull/13069#issuecomment-1120192073
> I have a few minor comments but let's also add a test case for this. Added. > This also isn't yet a full implementation of the Substrait spec as it doesn't handle nested fields. For example, if there are three columns and the first column is a struct column with two fields then the names vector should have 5 items in it. However, if we want to postpone naming of nested fields to a future PR I think that is fine, just make sure to add a JIRA for it. I opted to postpone, and updated the title and the [ARROW-15901](https://issues.apache.org/jira/browse/ARROW-15901) accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
