wjones127 commented on code in PR #2467:
URL: https://github.com/apache/arrow-datafusion/pull/2467#discussion_r867415428
##########
data-access/src/object_store/local.rs:
##########
@@ -50,17 +50,63 @@ impl ObjectStore for LocalFileSystem {
async fn list_dir(
&self,
- _prefix: &str,
- _delimiter: Option<String>,
+ prefix: &str,
+ delimiter: Option<String>,
) -> Result<ListEntryStream> {
- todo!()
+ if let Some(d) = delimiter {
+ if d != "/" && d != "\\" {
+ return Err(std::io::Error::new(
+ std::io::ErrorKind::InvalidInput,
+ format!("delimiter not supported on local filesystem: {}",
d),
+ ));
+ }
+ let mut entry_stream = tokio::fs::read_dir(prefix).await?;
+
+ let list_entries = stream::poll_fn(move |cx| {
Review Comment:
I could, but was attempting to not collect, just in case the caller didn't
want to collect all results in memory. It's definitely more verbose as a result
though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
