nealrichardson commented on PR #13082:
URL: https://github.com/apache/arrow/pull/13082#issuecomment-1121064569
> Looks like `skip_on_cran` does still work but the error pops while the
test are checked for unstated dependencies.
>
Ah, got it, that makes "sense".
> I removed the `iconv("Veitingastaðir", to = "latin1")` bit and tested it
with the string directly and the setup tests detect the wrong encoding, so as
far as I understand them the tests should still test the correct behavior.
>
> Should we remove the wrapper and move everything into `test-utf.R`?
Yeah, if trying to conceal a wonky file from CRAN isn't working anymore,
then we should just move it in to test-utf.R, and we probably don't need to
skip_on_cran either (though let's verify).
If you're removing latin1.R, search the repo for the couple of other places
where it is referenced and update those too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
