pitrou commented on a change in pull request #8084:
URL: https://github.com/apache/arrow/pull/8084#discussion_r481082824
##########
File path: cpp/src/arrow/ipc/read_write_test.cc
##########
@@ -968,7 +969,7 @@ struct StreamWriterHelper {
Status Init(const std::shared_ptr<Schema>& schema, const IpcWriteOptions&
options) {
ARROW_ASSIGN_OR_RAISE(buffer_, AllocateResizableBuffer(0));
sink_.reset(new io::BufferOutputStream(buffer_));
- ARROW_ASSIGN_OR_RAISE(writer_, NewStreamWriter(sink_.get(), schema,
options));
+ ARROW_ASSIGN_OR_RAISE(writer_, MakeStreamWriter(sink_.get(), schema,
options));
Review comment:
Same here.
##########
File path: cpp/examples/minimal_build/example.cc
##########
@@ -52,8 +52,8 @@ Status RunMain(int argc, char** argv) {
ARROW_ASSIGN_OR_RAISE(auto output_file,
arrow::io::FileOutputStream::Open(arrow_filename));
ARROW_ASSIGN_OR_RAISE(auto batch_writer,
- arrow::ipc::NewFileWriter(output_file.get(),
- table->schema()));
+ arrow::ipc::MakeFileWriter(output_file.get(),
Review comment:
Will do, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
