lidavidm commented on code in PR #13088:
URL: https://github.com/apache/arrow/pull/13088#discussion_r868116632
##########
cpp/src/arrow/dataset/dataset_test.cc:
##########
@@ -107,6 +111,38 @@ TEST_F(TestInMemoryDataset, InMemoryFragment) {
AssertSchemaEqual(batch->schema(), schema);
}
+TEST_F(TestInMemoryDataset, HandlesDifferingSchemas) {
+ constexpr int64_t kBatchSize = 1024;
+
+ // These schemas can be merged
+ SetSchema({field("i32", int32()), field("f64", float64())});
+ auto batch1 = ConstantArrayGenerator::Zeroes(kBatchSize, schema_);
+ SetSchema({field("i32", int64())});
+ auto batch2 = ConstantArrayGenerator::Zeroes(kBatchSize, schema_);
+ RecordBatchVector batches{batch1, batch2};
+
+ auto dataset = std::make_shared<InMemoryDataset>(schema_, batches);
Review Comment:
Hmm, good point about the fragments.
I was thinking InMemoryDataset already has all the data in memory, so it's
not a big deal anyways. But yes, that's unnecessary work compared to this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
