minyoung commented on code in PR #13068:
URL: https://github.com/apache/arrow/pull/13068#discussion_r868254860
##########
go/parquet/file/page_reader.go:
##########
@@ -611,8 +610,6 @@ func (p *serializedPageReader) Next() bool {
// we don't know this page type, we're allowed to skip
non-data pages
continue
}
-
- p.buf = memory.NewResizableBuffer(p.mem)
Review Comment:
Yes, that makes sense. PR rebased and updated.
I just wonder if `memory.NewBufferBytes(buf.Bytes())` would end up copying
the `[]byte` or not? Since both `memory.NewBufferBytes` and `buf.Bytes` both
use/pass references to the underlying `[]byte` and does not do any `copy`'s
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
