HaoYang670 commented on code in PR #1684:
URL: https://github.com/apache/arrow-rs/pull/1684#discussion_r869017080
##########
arrow/src/array/data.rs:
##########
@@ -1821,6 +1812,90 @@ mod tests {
.unwrap();
}
+ #[test]
+ fn test_empty_utf8_array_with_empty_offsets_buffer() {
+ let data_buffer = Buffer::from(&[]);
+ let offsets_buffer = Buffer::from(&[]);
+ ArrayData::try_new(
+ DataType::Utf8,
+ 0,
+ None,
+ None,
+ 0,
+ vec![offsets_buffer, data_buffer],
+ vec![],
+ )
+ .unwrap();
+ }
+
+ #[test]
+ fn test_empty_utf8_array_with_single_zero_offset() {
+ let data_buffer = Buffer::from(&[]);
+ let offsets_buffer = Buffer::from_slice_ref(&[0i32]);
+ ArrayData::try_new(
+ DataType::Utf8,
+ 0,
+ None,
+ None,
+ 0,
+ vec![offsets_buffer, data_buffer],
+ vec![],
+ )
+ .unwrap();
+ }
+
+ #[test]
+ #[should_panic(expected = "First offset 1 of Utf8 is larger than values
length 0")]
+ fn test_empty_utf8_array_with_invalid_offset() {
+ let data_buffer = Buffer::from(&[]);
+ let offsets_buffer = Buffer::from_slice_ref(&[1i32]);
+ ArrayData::try_new(
+ DataType::Utf8,
+ 0,
+ None,
+ None,
+ 0,
+ vec![offsets_buffer, data_buffer],
+ vec![],
+ )
+ .unwrap();
+ }
+
+ #[test]
+ fn test_empty_utf8_array_with_non_zero_offset() {
+ let data_buffer = Buffer::from_slice_ref(&"abcdef".as_bytes());
+ let offsets_buffer = Buffer::from_slice_ref(&[0i32, 2, 6, 0]);
Review Comment:
I think the offsets are weird but reasonable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
