pitrou commented on code in PR #12861:
URL: https://github.com/apache/arrow/pull/12861#discussion_r869041404
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -966,31 +1002,72 @@ else()
endif()
if(ARROW_BOOST_REQUIRED)
+ if(ARROW_BOOST_USE_SHARED)
+ # Find shared Boost libraries.
+ set(Boost_USE_STATIC_LIBS OFF)
+ set(BUILD_SHARED_LIBS_KEEP ${BUILD_SHARED_LIBS})
+ set(BUILD_SHARED_LIBS ON)
+ else()
+ # Find static boost headers and libs
+ # TODO Differentiate here between release and debug builds
Review Comment:
Yes, let's just remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
