pitrou commented on code in PR #13041:
URL: https://github.com/apache/arrow/pull/13041#discussion_r869082265
##########
cpp/src/arrow/ipc/writer.h:
##########
@@ -104,8 +104,7 @@ class ARROW_EXPORT RecordBatchWriter {
virtual Status WriteRecordBatch(
const RecordBatch& batch,
const std::shared_ptr<const KeyValueMetadata>& custom_metadata) {
- return Status::NotImplemented(
- "Write record batch with custom metadata not implemented");
+ return WriteRecordBatch(batch);
Review Comment:
Well, the default implementation can then be:
```c++
virtual Status WriteRecordBatch(
const RecordBatch& batch,
const std::shared_ptr<const KeyValueMetadata>& custom_metadata) {
if (custom_metadata == nullptr) {
return WriteRecordBatch(batch);
}
return Status::NotImplemented(
"Write record batch with custom metadata not implemented");
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
