andygrove commented on PR #2507: URL: https://github.com/apache/arrow-datafusion/pull/2507#issuecomment-1123115873
> LGTM. > > An off-topic question: I've noticed there were instructions on how to [get golden files](https://github.com/apache/arrow-datafusion/pull/34/files#diff-576c27794bae284efc278336a16d0649aaf599973a64d4b65dc67bc99bb7f000L37-L40) and get results verified but removed before. Do you think it's the time to add goldens and enable `verify_query` [here](https://github.com/apache/arrow-datafusion/blob/master/benchmarks/src/bin/tpch.rs#L914) for tpc-h? > > Currently, these tests are skipped `TPCH_DATA environment variable not set, skipping test ` The current approach is for developers to use the tpch toolkit to generate the expected answers locally and then set this env var to enable those tests. It would be nice if we could enable CI to do this as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
