pitrou commented on a change in pull request #8093:
URL: https://github.com/apache/arrow/pull/8093#discussion_r481935643
##########
File path: cpp/src/arrow/util/cpu_info.h
##########
@@ -101,6 +107,9 @@ class ARROW_EXPORT CpuInfo {
/// Returns the model name of the cpu (e.g. Intel i7-2600)
std::string model_name();
+ /// Returns whether or not the cpu is provided by this vendor.
+ bool IsVendor(Vendor vendor) const { return vendor == vendor_; }
Review comment:
It would seem more useful to expose the vendor directly:
```c++
Vendor vendor() const { ... }
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
