jonkeane commented on code in PR #12980:
URL: https://github.com/apache/arrow/pull/12980#discussion_r870654393
##########
.github/workflows/r.yml:
##########
@@ -177,6 +177,9 @@ jobs:
- { rtools: 40, arch: 'mingw32' }
- { rtools: 40, arch: 'mingw64' }
- { rtools: 40, arch: 'ucrt64' }
+ - { rtools: 42, arch: 'mingw32' }
+ - { rtools: 42, arch: 'mingw64' }
+ - { rtools: 42, arch: 'ucrt64' }
Review Comment:
It would be nice to have have a comment that explains this here (or below
where you have an rtools: 42 job that grabs an artifact with `...40...`
##########
.github/workflows/r.yml:
##########
@@ -177,6 +177,9 @@ jobs:
- { rtools: 40, arch: 'mingw32' }
- { rtools: 40, arch: 'mingw64' }
- { rtools: 40, arch: 'ucrt64' }
+ - { rtools: 42, arch: 'mingw32' }
+ - { rtools: 42, arch: 'mingw64' }
+ - { rtools: 42, arch: 'ucrt64' }
Review Comment:
It would be nice to have have a comment that explains this here (or below
where you have an rtools: 42 job that grabs an artifact with `...40...`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
