kou commented on code in PR #13122:
URL: https://github.com/apache/arrow/pull/13122#discussion_r870750399
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -1348,21 +1348,22 @@ macro(build_thrift)
${EP_COMMON_CMAKE_ARGS}
"-DCMAKE_INSTALL_PREFIX=${THRIFT_PREFIX}"
"-DCMAKE_INSTALL_RPATH=${THRIFT_PREFIX}/lib"
+ # Work around https://gitlab.kitware.com/cmake/cmake/issues/18865
+ -DBoost_NO_BOOST_CMAKE=ON
-DBUILD_COMPILER=OFF
+ -DBUILD_EXAMPLES=OFF
-DBUILD_SHARED_LIBS=OFF
-DBUILD_TESTING=OFF
- -DBUILD_EXAMPLES=OFF
-DBUILD_TUTORIALS=OFF
- -DWITH_QT4=OFF
Review Comment:
Could you add `-DWITH_QT5=OFF` instead?
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -1348,21 +1348,22 @@ macro(build_thrift)
${EP_COMMON_CMAKE_ARGS}
"-DCMAKE_INSTALL_PREFIX=${THRIFT_PREFIX}"
"-DCMAKE_INSTALL_RPATH=${THRIFT_PREFIX}/lib"
+ # Work around https://gitlab.kitware.com/cmake/cmake/issues/18865
+ -DBoost_NO_BOOST_CMAKE=ON
-DBUILD_COMPILER=OFF
+ -DBUILD_EXAMPLES=OFF
-DBUILD_SHARED_LIBS=OFF
-DBUILD_TESTING=OFF
- -DBUILD_EXAMPLES=OFF
-DBUILD_TUTORIALS=OFF
- -DWITH_QT4=OFF
+ -DWITH_AS3=OFF
+ -DWITH_CPP=ON
-DWITH_C_GLIB=OFF
-DWITH_JAVA=OFF
- -DWITH_PYTHON=OFF
- -DWITH_HASKELL=OFF
- -DWITH_CPP=ON
- -DWITH_STATIC_LIB=ON
+ -DWITH_JAVASCRIPT=OFF
-DWITH_LIBEVENT=OFF
- # Work around https://gitlab.kitware.com/cmake/cmake/issues/18865
- -DBoost_NO_BOOST_CMAKE=ON)
+ -DWITH_NODEJS=OFF
+ -DWITH_PYTHON=OFF
+ -DWITH_STATIC_LIB=ON)
Review Comment:
Could you also add `-DWITH_ZLIB=OFF`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
