jorisvandenbossche commented on PR #10162: URL: https://github.com/apache/arrow/pull/10162#issuecomment-1124859340
Sorry for the late reply, but personally I am still not in favor of merging this _unless_ we first have a discussion about what exactly we regard as public cython API and document this. This PR will break for example the current `cudf` package. Of course it's an easy fix for them to just change the import, but if they do change that import, do we then give any guarantee that we won't change it again in the future? (i.e. do we "bless" the usage of this cython API, or do we actually want that they do not use this cython API at all?) And if they change the import, they would (with the current PR) need to import it from a private module (`pyarrow._ipc`), which seems to indicate that they actually shouldn't do that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
