dragosmg commented on code in PR #13118:
URL: https://github.com/apache/arrow/pull/13118#discussion_r871361909
##########
r/R/dplyr-funcs-datetime.R:
##########
@@ -518,6 +518,28 @@ register_bindings_datetime_parsers <- function() {
coalesce_output <- build_expr("coalesce", args = parse_attempt_expressions)
- build_expr("assume_timezone", coalesce_output, options = list(timezone =
tz))
+ if (!is.null(tz)) {
+ build_expr("assume_timezone", coalesce_output, options = list(timezone =
tz))
+ } else {
+ coalesce_output
+ }
+
})
+
+ ymd_parser_vec <- c("ymd", "ydm", "mdy", "myd", "dmy", "dym")
+
+ ymd_parser_map_factory <- function(order) {
+ force(order)
Review Comment:
I think technically, we can get away without using `force()` here, but it's
a bit more robust with it than without it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
