westonpace commented on code in PR #13078:
URL: https://github.com/apache/arrow/pull/13078#discussion_r871866656
##########
cpp/src/arrow/engine/substrait/serde_test.cc:
##########
@@ -750,5 +750,309 @@ TEST(Substrait, ExtensionSetFromPlanMissingFunc) {
&ext_set));
}
+TEST(Substrait, JoinPlanBasic) {
Review Comment:
I'm not so much worried about where the text lives as I am worried about
maintaining the text itself. On the other hand, any approach I can think of
for automatically generating the text devolves into creating Ibis/dplyr for C++
:laughing:
Still, those tools exist for a reason, writing these things manually is
cumbersome.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
