westonpace commented on code in PR #13117:
URL: https://github.com/apache/arrow/pull/13117#discussion_r872149598
##########
cpp/src/arrow/dataset/file_test.cc:
##########
@@ -349,18 +349,17 @@ TEST_F(TestFileSystemDataset, WriteProjected) {
}
class FileSystemWriteTest : public testing::TestWithParam<std::tuple<bool,
bool>> {
+ using PlanFactory = std::function<cp::Declaration(
+ const FileSystemDatasetWriteOptions&,
+ std::function<Future<util::optional<cp::ExecBatch>>()>*)>;
+
Review Comment:
I did think about this but I would like to start generally improving our
test code for exec plans. I think we are a little sparse at the moment and it
is rather complex to create some of these unit tests. I'll try and wrap this
up tomorrow and if not I can leave the bonus utilities for a future PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
